[pacman-dev] [RFC][PATCH] Introduce Include key globing for pacman.conf v4

Dan McGee dpmcgee at gmail.com
Sun Nov 15 21:04:23 EST 2009

On Sun, Nov 15, 2009 at 9:00 AM, Xavier <shiningxc at gmail.com> wrote:
> On Mon, Oct 12, 2009 at 4:06 AM, Dan McGee <dpmcgee at gmail.com> wrote:
>> On Fri, Sep 11, 2009 at 5:35 AM, Marc - A. Dahlhaus [ Administration |
>> Westermann GmbH ] <mad at wol.de> wrote:
>>> This patch adds the ability to use Include filenames
>>> containing wildcards.
>>> Added a headercheck for glob.h to configure.ac.
>>> Added a globfree call to clean up the struct properly.
>>> Removed tilde expanding.
>>> Fixed a no debug print on GLOB_NOMATCH condition bug.
>>> Signed-off-by: Marc-A. Dahlhaus <mad at wol.de>
>>> ---
>> Xavier, comments here? I kind of dropped this one on the floor, but a
>> quick review and I think it is good.
> I am still not convinced that this is terribly useful. But its like 10
> lines, so no big deal :)
> http://mailman.archlinux.org/pipermail/pacman-dev/2009-September/009361.html
> Like, if it's used for repos, you cannot even control their priority ?
> Sounds like a show-stopper to me.
> If not for repos, what else ?

Yeah, this is an interesting problem. I'm not sure glob() is even
guaranteed to return results in a known (e.g. alphabetical) order.
Also, looking at this, if glob returns NOSPACE, we should probably
pull out the fireworks and blow up- running pacman half-configured
would be no good.

I'm also thinking of how many reports we are going to get of people
doing recursive self-includes, but maybe I'm making a problem from
nothing here.


More information about the pacman-dev mailing list