[pacman-dev] [PATCH 2/2] makepkg: allow to specify an alternative pacman command

Allan McRae allan at archlinux.org
Mon Nov 30 22:02:05 EST 2009


Dan McGee wrote:
> On Thu, Nov 19, 2009 at 10:14 PM, Allan McRae <allan at archlinux.org> wrote:
>>> @@ -350,7 +350,7 @@ check_deps() {
>>>        if (( ret == 127 )); then #unresolved deps
>>>                echo "$pmout"
>>>        elif (( ret )); then
>>> -               error "$(gettext "Pacman returned a fatal error (%i):
>>> %s")" "$ret" "$pmout"
>>> +               error "$(gettext "%s returned a fatal error (%i): %s")"
>>> "${PACMAN##*/}" "$ret" "$pmout"
>> Should we also strip any flags provided in the PACMAN variable?  e.g. I
>> could set PACMAN="pacman -v" for verbose output.  I guess some wrappers
>> might have flags that would be useful to specify.
> 
> I would say no to this; if a person wants flags then we shouldn't mess
> with them.

Me too, thinking about it now....   The flag could be causing the return 
failure so it is important to keep it there.




More information about the pacman-dev mailing list