[pacman-dev] [PATCH] Introduce new PKGBUILD variable `changelog`

[Xavier]

On Sat, Oct 10, 2009 at 4:34 PM, Dan McGee <dpmcgee at gmail.com> wrote:
> On Thu, Oct 8, 2009 at 9:10 AM, Cedric Staniewski <cedric at gmx.ca> wrote:
>> Hi,
>>
>> This patch adds a new PKGBUILD variable, changelog, which replaces the old, hardcoded ChangeLog file. The old behavior is completely removed, which means that existing ChangeLog files will be ignored if there is no appropriate line in the PKGBUILD. For a more detailed description, please see the patch below.
>>
>> I hope I also caught all the necessary documentation updates.
>>
>> Cedric
>>
>>
>> >From d8e1bb73705a665bc03f14f4eb3ec0d8b9e6d259 Mon Sep 17 00:00:00 2001
>> From: Cedric Staniewski <cedric at gmx.ca>
>> Date: Wed, 16 Sep 2009 14:38:18 +0200
>> Subject: [PATCH] Introduce new PKGBUILD variable `changelog`
>>
>> Currently, a changelog is added to a package if a specific file with a
>> hardcoded name exists in the PKGBUILD's directory. This approach is not
>> pretty and also inconsistent with the handling of install files, but it
>> works.
>>
>> With the introduction of split PKGBUILDs, however, a drawback in this
>> old behavior has arisen: you only have the possibility to include one
>> specific changelog file in either every package defined in the PKGBUILD
>> or in none.
>>
>> The use of an additional variable, `changelog`, works around this issue
>> and makes it possible to include a changelog in only some of the
>> packages, and besides, each package of the PKGBUILD can have its own
>> changelog file.
>>
>> Signed-off-by: Cedric Staniewski <cedric at gmx.ca>
>
> I don't have a problem with this. The changelog stuff was originally
> added by Aaron in early 2007, so any comments from him? Commit
> 0635e03869a9af0b40ba2858a88de0d2e6dd8fe7.
>
> Xavier and Allan. always looking for your input as well. :)
>

This looked good to me.