[pacman-dev] [PATCH] Change strdup function using for strndup

[Laszlo Papp]

On Sun, Oct 18, 2009 at 5:38 PM, Dan McGee <dpmcgee at gmail.com> wrote:

> On Sat, Oct 17, 2009 at 11:40 PM, Laszlo Papp <djszapi2 at gmail.com> wrote:
> >        * Size examined str* function usage is a common coding practice,
> >        *       because it's more safer to avoid breakage while using str*
> functions.
> >
> > Signed-off-by: Laszlo Papp <djszapi at archlinux.us>
> > ---
> > @@ -189,7 +189,7 @@ char *mdirname(const char *path)
> >        }
> >        /* no slash found */
> >        free(ret);
> > -       return(strdup("."));
> > +       return(strndup(".", PATH_MAX));
> >  }
> >
>
> Um...what? Really?
>
> -Dan
>
>
It doesn't cause problem, but if you change "." for a variable it will be
more reasonable. But I can remove such lines from the patch, if otherwise
it's okay.

Thanks the feedback.

Best Regards,
Laszlo Papp