[pacman-dev] [PATCH] makepkg: remove .part file after a failed download

[Cedric Staniewski]

Xavier wrote:
> On Wed, Oct 21, 2009 at 7:38 PM, Cedric Staniewski <cedric at gmx.ca> wrote:
>> Actually never thought about that since I did not experience a disrupted download so far. Therefore, the only .part files I saw were empty ones, because the source did not existed anymore or the url was just wrong.
>>
>> Attached a new patch which should only remove the empty .part files. Thanks for the pointer.
>>
>>
> 
> I am far from being a hardcore makepkg user, but I still find it
> strange that I never saw this happening.
> I would expect the download program to not create empty .part files
> when the source is wrong.
> Did you change the dlagent somehow ?

I don't think so.


> DLAGENTS=('ftp::/usr/bin/wget -c --passive-ftp -t 3 --waitretry=3 -O %o %u'
>           'http::/usr/bin/wget -c -t 3 --waitretry=3 -O %o %u'
>           'https::/usr/bin/wget -c -t 3 --waitretry=3 --no-check-certificate -O %o %u'
>           'rsync::/usr/bin/rsync -z %u %o'
>           'scp::/usr/bin/scp -C %u %o')


> Did you try to run the download programs directly, without using makepkg ?

Just did that:

$ ls -s
total 0
$ /usr/bin/wget -c -t 3 --waitretry=3 -O "Baralga-Portable-1.4.4-SNAPSHOT.zip.part" "http://download.origo.ethz.ch/baralga/147/Baralga-Portable-1.4.4-SNAPSHOT.zip"
--2009-10-21 19:51:31--  http://download.origo.ethz.ch/baralga/147/Baralga-Portable-1.4.4-SNAPSHOT.zip
Resolving download.origo.ethz.ch... 129.132.103.135, 2001:620:8:1000::15
Connecting to download.origo.ethz.ch|129.132.103.135|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2009-10-21 19:51:31 ERROR 404: Not Found.

$ ls -s
total 0
0 Baralga-Portable-1.4.4-SNAPSHOT.zip.part


> 
> Though I have to admit I did not check this behavior yet, I will check
> later today.