[pacman-dev] [PATCH] makepkg: remove .part file after a failed download

[Ray Rashif]

2009/10/22 Xavier <shiningxc at gmail.com>

> On Wed, Oct 21, 2009 at 7:38 PM, Cedric Staniewski <cedric at gmx.ca> wrote:
> > -       eval $dlcmd || return $?
> > +       eval $dlcmd
> > +       local ret=$?
> > +       if [ $ret -gt 0 ]; then
> > +               [ ! -s "$dlfile" ] && rm -f -- "$dlfile"
> > +               return $ret
> > +       fi
> >
>
> I don't understand, I cannot get it to work.
> It looks like when "eval $dlcmd" fails, nothing else is run in that
> function.
>
> I added a echo statement, but I still only see that message at the end :
> ==> ERROR: An unknown error has occurred. Exiting...
>

looks like there is no return to handle (fail but no reason given), so
makepkg traps that.