[pacman-dev] [PATCH] makepkg: check for non-empty pkgbase instead of pkgname

[Allan McRae]

Cedric Staniewski wrote:
> Allan McRae wrote:
>   
>> Dan McGee wrote:
>>     
>>> On Wed, Oct 21, 2009 at 9:06 AM, Cedric Staniewski <cedric at gmx.ca> wrote:
>>>  
>>>       
>>>> pkgbase is used in the following rm calls, and since pkgname can be
>>>> present when pkgbase is not, it is safer to check for pkgbase.
>>>>
>>>> Signed-off-by: Cedric Staniewski <cedric at gmx.ca>
>>>>     
>>>>         
>>> Looks good to me, Allan?
>>>
>>> -Dan
>>>   
>>>       
>> Makes sense to me.  Although, I believe there is no way for makepkg to
>> exit cleanly after sourcing the PKGBUILD without the setting of pkgbase.
>>
>> Pushed to my working branch.
>>
>> Allan
>>     
>
> The, probably only, operation, which is affected by this, is '-gc'.
>   

Good catch.

Allan