[pacman-dev] [PATCH] makepkg: check for references to build root in package

Allan McRae allan at archlinux.org
Sun Oct 25 19:08:21 EDT 2009


Xavier wrote:
> On Sun, Oct 25, 2009 at 7:26 PM, Cedric Staniewski <cedric at gmx.ca> wrote:
>   
>>> No reason....   I was going to adjust my patch to this syntax.
>>> However, I have discovered, the patch causes makepkg to halt if there
>>> are no files in ${pkgdir}.  This is entirely possible with something
>>> like "meta-packages" which just contain a list of deps.  So I am going
>>> to need to use some sort of "grep ... || ret=" syntax anyway.
>>>
>>> Allan
>>>
>>>       
>> I tried to reproduce this, but was not able to do so.
>>
>>     
>
> Ah this is what I forgot to ask Allan today.
>
> I wanted to tell him I didn't understand why grep would get stuck, and
> why this other syntax would change anything about it.
>   

I have no idea....   Yesterday when trying the "if grep" syntax, makepkg 
would just stop directly before outputing "Creating package".  I assumed 
it was something due to "set -e".   Strange thing is, I can not 
replicate it today...   even after pulling the stashed changes I had 
saved so I could go back and figure it out.  I might be going mad...

I have adjusted the patch to use Cedric's syntax now that it is working 
for me.

Allan



More information about the pacman-dev mailing list