[pacman-dev] [isaac.otherinbox.com] Re: Patch makepkg to use more [[ and (( bash syntax

Dan McGee dpmcgee at gmail.com
Mon Oct 26 22:22:14 EDT 2009


On Mon, Oct 26, 2009 at 9:17 PM, Isaac Good <pacman at isaac.otherinbox.com> wrote:
> On Mon, Oct 26, 2009 at 2:52 AM, Allan McRae <allan at archlinux.org> wrote:
>> Part of that is obviously due to a not fully rebased git repo
>> ("${ARGLIST[@]}" changes).   As an aside, $newpkgver can never contain a
>> space so quotes are unneeded.
>
> If you are referring specifically to ARGLIST, the ARGLIST variable
> only appears 3 times in the file. Bases on those 3 occurrences, this
> change should have no affect other than preserving spaces in arguments
> (and preserving the $@ as the array it is).

See the change I had pushed to maint but just merged into master; we
had this taken care of already.

Separate patches for separate changes are always appreciated around
here, even if the patch series depends on a previous one. It makes for
much easier reviewing and subsequent approval.

-Dan


More information about the pacman-dev mailing list