[pacman-dev] [PATCH] Feedback from installed package while searching

Nagy Gabor ngaba at bibl.u-szeged.hu
Thu Sep 3 16:31:35 EDT 2009


> On Thu, Sep 3, 2009 at 9:54 PM, Nagy Gabor<ngaba at bibl.u-szeged.hu> wrote:
> >
> > What is wrong with printf(_(" [installed]"));?
> >
> > For my taste, printing [installed] when I have _older version_
> > installed, a bit strange. In this case [installed: 2.0-1] would be
> > better (but harder to parser).
> >
> 
> Afaik, it is always safer to avoid putting non-fixed strings as the
> first argument of printf.
> 
> if a bogus translation put some format strings as the translation of
> installed, it could do weird things.

That is true, but then these kind of lines are also "dangerous":

printf(_("                       This program may be freely redistributed under\n"
         "                       the terms of the GNU General Public License.\n"));

Then e should use printf("%s",_()) or puts.

Btw, with c-format, the appropriate gettext tool should catch bogus translation.

Bye




More information about the pacman-dev mailing list