[pacman-dev] [PATCH] Fix "-Sd conflict_pkg" bug

Xavier shiningxc at gmail.com
Sat Sep 12 16:07:19 EDT 2009


On Sat, Sep 12, 2009 at 10:01 PM, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> If the -d switch was invoked with -S (or -U), the removes list was simply
> lost, because trans->remove was computed in an
> "if(!(trans->flags & PM_TRANS_FLAG_NODEPS))" block.
>
> I've added a new pactest file, sync045.py (derived from sync043.py) to test
> this.
>
> Additionally, I did some other minor cleanups in sync_prepare:
>  * preferred list is not needed anymore
>  * I removed a needless alpm_list_remove_dupes line (the target list should
>   not contain dupes at all)
>  * I moved alpm_list_free(remove); to cleanup part to eliminate a possible
>   memleak
>
> Signed-off-by: Nagy Gabor <ngaba at bibl.u-szeged.hu>

Signed-off-by: Xavier <shiningxc at gmail.com>


More information about the pacman-dev mailing list