[pacman-dev] [PATCH] Ask user confirmation for -R operation, too

[Dan McGee]

On Tue, Sep 15, 2009 at 5:47 AM, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> After commit 0da96abc, pacman always asks user confirmation for -U, so it is
> more coherent for doing that for -R, too.
>
> Btw, most users use -Rs always, so they won't notice any change. In the old
> code the -Ru operation was forgotten: Though it is not "dangerous", but the
> target list can be changed by that operation too.
>
> Non-interactive scripts should use --noconfirm always (unexpected questions
> can be asked by all transactions). [That's we should always default to the
> safest answers.]
>
> I also added a pkglist != NULL sanity check (because -Ru can empty target
> list in trans_prepare part).
>
> Signed-off-by: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> ---
>  src/pacman/remove.c |   26 +++++++++++---------------
>  1 files changed, 11 insertions(+), 15 deletions(-)

Looks good to me, anyone else?