[pacman-dev] [PATCH] Remove makepath function from frontend

Xavier shiningxc at gmail.com
Sat Sep 26 17:24:22 EDT 2009


On Sat, Sep 26, 2009 at 7:39 PM, Laszlo Papp <djszapi2 at gmail.com> wrote:
>    Remove makepath function from pacman frontend, because
>    _alpm_makepath(_mode) is good enough from the libalpm API, so
>    it was duplicated in fact, and this function from the API may be
>    paramiterized with permission rights, while makepath from frontend not.
>    It's a cleaning activity too, at last it wasn't used.
>
>    ./src/pacman/util.c:
>        - this source code contained the makepath() function definition
>    ./src/pacman/util.h:
>        - this header file contained the makepath() function declaration
>

Your commit is confusing. It makes it sound like we could use
_alpm_makepath from the frontend which is not true at all.

This commit should rather be :
remove makepath from the frontend because it is no longer used
(the code using it has probably moved to the backend and we have
_alpm_makepath there)

There are several other functions which are duplicated between backend
util.c and frontend util.c , but there is nothing we can do against
it.


More information about the pacman-dev mailing list