[pacman-dev] Include globbing - Was: Release plans

[Marc - A. Dahlhaus [ Administration | Westermann GmbH ]]

Am Samstag, den 24.04.2010, 23:34 +1000 schrieb Allan McRae:
> On 24/04/10 23:15, Allan McRae wrote:
> > On 23/04/10 22:50, Marc - A. Dahlhaus [ Administration | Westermann GmbH
> > ] wrote:
> >> Am Freitag, den 23.04.2010, 19:32 +1000 schrieb Allan McRae:
> >>> On 23/04/10 18:02, Marc - A. Dahlhaus [ Administration | Westermann GmbH
> >>> ] wrote:
> >>>> The include globbing patch. :)
> >>>
> >>> Any chance of a flyspray/mailing list link to the patch?
> >>
> >> Patch:
> >> http://mailman.archlinux.org/pipermail/pacman-dev/2010-March/010550.html
> >>
> >> Original thread:
> >> http://mailman.archlinux.org/pipermail/pacman-dev/2009-September/009355.html
> >>
> >>
> >> Discussion:
> >> http://mailman.archlinux.org/pipermail/pacman-dev/2009-October/009711.html
> >>
> >> http://mailman.archlinux.org/pipermail/pacman-dev/2009-November/010158.html
> >>
> >> http://mailman.archlinux.org/pipermail/pacman-dev/2010-March/010551.html
> >>
> >
> > Thanks. I think I have no objection to this patch... The code is fine, I
> > am just unsure about the use cases. Mind you, with pacman hooks in the
> > future, we might want to have "Include /etc/pacman/hooks/*".
> >
> > One query, does this handle the case where there is nothing in the
> > globbed folder? Is that the GLOB_ABORTED case?
> 
> In fact, it looks like it does not handle that case and it is probably 
> not a good thing if that is struck.  A case GLOB_NOMATCH with just a 
> debug message should be fine.

It handled the GLOB_NOMATCH case silently in the default handler.
But a debug print would help alot eg. on typos in include rules.
You can find an altered version attached.

Thanks for the feadback,

Marc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pacman-glob-v5.patch
Type: text/x-patch
Size: 2379 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20100426/6efcd024/attachment.bin>