[pacman-dev] [PATCH] makepkg: Allow creation of uncompressed packages

Dan McGee dpmcgee at gmail.com
Sun Aug 8 11:23:41 EDT 2010


On Sat, Aug 7, 2010 at 5:47 AM, Thomas Bächler <thomas at archlinux.org> wrote:
> When performing local testing, it may be useful to add PKGEXT='.pkg.tar'
> to the PKGBUILD to save time, especially with big packages.
> ---
>  scripts/makepkg.sh.in |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 32528b0..1b788ef 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -1031,6 +1031,7 @@ create_package() {
>                *tar.gz)  EXT=${PKGEXT%.gz} ;;
>                *tar.bz2) EXT=${PKGEXT%.bz2} ;;
>                *tar.xz)  EXT=${PKGEXT%.xz} ;;
> +               *tar)     EXT=${PKGEXT} ;;
>                *) warning "$(gettext "'%s' is not a valid archive extension.")" \
>                "$PKGEXT" ; EXT=$PKGEXT ;;
>        esac
> @@ -1050,6 +1051,7 @@ create_package() {
>                        *tar.gz)  gzip -f -n "$tar_file" ;;
>                        *tar.bz2) bzip2 -f "$tar_file" ;;
>                        *tar.xz)  xz -z -f "$tar_file" ;;
> +                       *tar)     true ;;
>                esac
>                ret=$?
>        fi
> @@ -1125,6 +1127,7 @@ create_srcpackage() {
>                *tar.gz)  TAR_OPT="z" ;;
>                *tar.bz2) TAR_OPT="j" ;;
>                *tar.xz)  TAR_OPT="J" ;;
> +               *tar)     TAR_OPT=""  ;;
>                *) warning "$(gettext "'%s' is not a valid archive extension.")" \
>                "$SRCEXT" ;;
>        esac
> --

This looks fine to me; the only thing I see odd is that we still use
two different methods of compression between create_package() and
create_srcpackage(). Worth unifying?

-Dan


More information about the pacman-dev mailing list