[pacman-dev] [PATCH] makepkg: perform sanity checks on variables in package functions

Allan McRae allan at archlinux.org
Tue Dec 7 12:52:17 CET 2010


On 07/12/10 21:29, jeff at kcaccess.com wrote:
>> Check the over-ridden entries for provides, backup and optdepends
>> for illegal entries.  Fixes FS#16004.
>
> Please don't take this as an assertion of what is right or wrong. I'm just
> posing the question. Are these checks stepping on namcap's domain?
>

I'm going for a "not really" there...   Most of these are basic checks 
to avoid failures later in the package building process.   Others are 
important for future pacman development (e.g. forcing syntax of 
optdepends would allow us to parse them in pacman).

Although some are things that namcap could check (e.g. checking leading 
/ in backup entries).  But the overhead for those is so minimal that I 
think that having them in makepkg is fine.

Allan


More information about the pacman-dev mailing list