[pacman-dev] [PATCH] Declare all local functions static

Xavier Chantry chantry.xavier at gmail.com
Sun Dec 19 05:53:45 EST 2010

On Sun, Dec 19, 2010 at 2:31 AM, Allan McRae <allan at archlinux.org> wrote:
> be_local.c:70:13: warning: no previous prototype for '_cache_get_filename'
> [-Wmissing-prototypes]
> -Wmissing-prototypes aims to detect global functions that fail to be
> declared in header files.  Given we probably do not want to declare those in
> a header file and they are restricted to that one translation unit, I
> figured they should all be declared static...

Just a side note: once you have gotten pacman fully compliant against
a gcc option like this one, maybe it could be added to the Makefile so
that we could spot all these small problems during dev ?

More information about the pacman-dev mailing list