[pacman-dev] [PATCH] makepkg: print only base filename of install/changelog files

[Dan McGee]

On Thu, Jun 3, 2010 at 10:33 AM, Cedric Staniewski <cedric at gmx.ca> wrote:
> The complete file path of a temporary symlink is really useless
> information.
>
> Signed-off-by: Cedric Staniewski <cedric at gmx.ca>
> ---
>  scripts/makepkg.sh.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index c5ce2a2..13feab1 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -1112,7 +1112,7 @@ create_srcpackage() {
>                        # evaluate any bash variables used
>                        eval file='${srclinks}/${pkgbase}/'${file}
>                        if [[ ! -f $file ]]; then
> -                               msg2 "$(gettext "Adding %s file (%s)...")" "$i" "$file"
> +                               msg2 "$(gettext "Adding %s file (%s)...")" "$i" "${file##*/}"

Not really sure what the right answer is, but what is the reasoning
not to use something like `basename` here? Obviously this is a bit
faster but there is a utility for this that must have some practical
purpose.

>                                ln -s "${startdir}/$file" "${srclinks}/${pkgbase}/"
>                        fi
>                done
> --
> 1.7.1
>
>
>