[pacman-dev] [PATCH] Fix creation of source packages

Cedric Staniewski cedric at gmx.ca
Wed Jun 9 12:23:48 EDT 2010

On 09.06.2010 05:53, Allan McRae wrote:
> Source packages were getting created with only links to local source
> files.  Caused by commit 5cddcc90.

Wow, I managed to sneak in a bug in the last iteration and instead of
fixing --allsource it broke source package creation completely. :D

Thanks for finding and fixing this before the release. I think I've only
checked if the file existed (bsdtar tf) in the last iteration. However,
I've also expected bsdtar to warn of dangling symlinks when using the -L
option. Maybe it is supposed to do so, but if not, we may want to add
--check-links (-l) when that option is fixed[1].

[1] http://code.google.com/p/libarchive/issues/detail?id=82

More information about the pacman-dev mailing list