[pacman-dev] [PATCH 10/11] makepkg: do not ask sudo password twice
Allan McRae
allan at archlinux.org
Thu Jun 17 09:34:47 EDT 2010
On 17/06/10 23:28, Andres P wrote:
> On Thu, Jun 17, 2010 at 8:49 AM, Allan McRae<allan at archlinux.org> wrote:
>> On 17/06/10 22:44, Andres P wrote:
>>>
>>> Fixes a regression in 05ff276eefc with passwd_timeout=0 in sudoers.
>>>
>>> Passwords were being asked twice for *every* operation.
>>>
>>> Signed-off-by: Andres P<aepd87 at gmail.com>
>>> ---
>>>
>>> makepkg shouldn't make assumptions about the site's security settings,
>>> specially something as innocuous as passwd_timeout.
>>>
>>> A cleaner way that also involves less forks is to process sudo's $?, if
>>> possible:
>>> sudo $PACMAN $PACMAN_OPTS "$@" || ret=$?
>>> if [[ $? = 4 ]]; then
>>> error "$(gettext "You are not authorized to use sudo
>>> pacman.")"
>>> exit $E_AUTH
>>> fi
>>> Note that 4 is just an example
>>>
>>
>>
>> I do not understand you at all here... As far as I can tell, "sudo -l"
>> never asks for a password. Also, passwd_timeout=0 sets sudo to only ever
>> ask for a password once. I am completely lost at what you are trying to
>> achieve with this!
>>
>> Allan
>>
>
> My bad, it's timestamp_timeout
>
> Run pacman 3.3's makepkg with timestamp_timeout=0 then 3.4...
>
> It will ask you twice
>
>
> Actually, just do this
>
> sudo -l /bin/true&& sudo /bin/true
>
> *with* timestamp_timeout=0
>
Um... no it does not... sudo -l does not ask for a password even with
timestamp_timeout=0.
Allan
More information about the pacman-dev
mailing list