[pacman-dev] [PATCH 07/11] makepkg: less code repetition when sanitizing variable contents

[Andres P]

On Thu, Jun 17, 2010 at 9:39 AM, Dan McGee <dpmcgee at gmail.com> wrote:
> Helpful error messages are what is there now- I understand the want to
> reduce the repetition but not at the expense of the user understanding
> what was wrong. I think this message is better but still not ideal as
> you then have to decipher the regex.
>
That's just a random idea. I could restore the messages and keep the rep
down... but first there *has* to be an incentive to not copy paste code.

If we agree that it needs less copy paste then we can work an error message
out, which is the least difficult thing to do.

>> And if makepkg has code repetition because of documentation, then the
>> man page out to be fixed? Not that the error message is less
>> descriptive as it is anyhow.
>
> I don't follow what you are saying here- I think we have a language
> barrier. What does the manpage have to do with anything?
>

I'm implying that these verbose descriptions would fit better in the manpage.

The manpage would have a section on explaining what and what cannot go in a
field.

Whereas makepkg will just throw an error with the string that matched the
pattern.

Again, that is contradictory to what I posted in reply above... but it can be
worked out *if* there's interest in less copy paste.

I'm percieving that there is not.

Andres P