[pacman-dev] [PATCH] makepkg: do not ignore errors from pacman

Allan McRae allan at archlinux.org
Sun Jun 20 00:03:41 EDT 2010


On 20/06/10 12:13, Andres P wrote:
> * check_deps is being run in a subshell, so exit 1 has no meaning.

If a line of code has no meaning, remove it. Perhaps add a comment why 
there is not exit after the error.

Otherwise the patch is fine.

Allan


More information about the pacman-dev mailing list