[pacman-dev] [PATCH] Add check() function for testsuites.

Jeff jeff at kcaccess.com
Sun Jun 20 16:00:33 EDT 2010


On Sat, Jun 19, 2010 at 02:41:02PM +1000, Allan McRae wrote:
> 
> This is a feature that is acceptable. But I do not like using an 
> option=() value to decide whether to run it.  I would prefer a "--check" 
> option to be added.   Then people can choose to run the check function 
> or not without requiring to edit the PKGBUILD.  If they always want 
> check() to be run, an alias for makepkg can be used.

Actually, I never envisioned this to be used in the PKGBUILDs other than
for a very few critical packages (toolchain) where it doesn't make sense
to not test. IMO, this would better be suited as an edited value in
makepkg.conf per the builders's desire the same as whether he wants the
doc directory wiped. The use of an alias in this case would serve
nothing more than to override a global directive, which ISTM is what
~/.makepkg.conf is for.

> That is unrelated to the patch...

Oops, slipped in by accident. Thanks for the notice.

-- 
Jeff

My other computer is an abacus.



More information about the pacman-dev mailing list