[pacman-dev] [PATCH] makepkg: clarify aborting on packaging failure

[Allan McRae]

On 30/06/10 22:33, Dan McGee wrote:
> On Wed, Jun 30, 2010 at 7:22 AM, Allan McRae<allan at archlinux.org>  wrote:
>> When makepkg catches a command failure it currently prints "Aborting..."
>> and exits.  Clarify the reason for aborting from packaging is a command
>> failure.
>>
>> Signed-off-by: Allan McRae<allan at archlinux.org>
>> ---
>>
>> The message is still crap...  Any ideas for better clarity?
>>
>>   scripts/makepkg.sh.in |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
>> index cbc344d..a21a672 100644
>> --- a/scripts/makepkg.sh.in
>> +++ b/scripts/makepkg.sh.in
>> @@ -721,6 +721,7 @@ error_function() {
>>         fi
>>         # first exit all subshells, then print the error
>>         if (( ! BASH_SUBSHELL )); then
>> +               error "$(gettext "A command failure occurred during packaging.")"
> It can occur in either function, right? This is skewed towards
> package() rather than build().
>
> What about "Aborting due to failure in $funcname"?

Hmm...  it turns out you can pass parameters to error trap functions so 
that will work.

Thanks.