[pacman-dev] [PATCH 3/4] Build vercmp without needing link to libalpm

[Allan McRae]

On 05/05/10 22:55, Dan McGee wrote:
> On Wed, May 5, 2010 at 1:05 AM, Allan McRae<allan at archlinux.org>  wrote:
>> On 05/05/10 14:45, Dan McGee wrote:
>>>
>>> Include the object file directly from the libalpm version comparison code
>>> as
>>> it is the only thing we need. This drops the dependency of vercmp on
>>> libalpm and all of the stuff we know it drags in.
>>>
>>> Signed-off-by: Dan McGee<dan at archlinux.org>
>>> ---
>>
>> <snip>
>>
>> After applying the four patches from this patchset:
>>
>>> readelf -d src/util/vercmp
>>
>> Dynamic section at offset 0xdfc contains 21 entries:
>>   Tag        Type                         Name/Value
>>   0x00000001 (NEEDED)                     Shared library: [libssp.so.0]
>>   0x00000001 (NEEDED)                     Shared library: [libc.so.6]
>> ...
>>
>> libssp is part of gcc(-libs), so linking to that is probably not a disaster.
>>   But is it still not needed for the current Arch vercmp so may be worth
>> looking into.
>
> The ssp comes from here:
> http://projects.archlinux.org/pacman.git/tree/configure.ac#n291
>
> See the GCC_STACK_PROTECT_* macros listed there, which are turned on
> in debug builds (and for now not in production builds, although there
> is a feature request in Arch in general to add that).

Ugh...  I can believe I did not think about that!

Full ack on all patches then.
Allan