[pacman-dev] [PATCH] rankmirrors: Add a --repo option to target a specific repo

[Dan McGee]

On Thu, May 6, 2010 at 10:45 PM, Daenyth Blank <daenyth+arch at gmail.com> wrote:
> On Thu, May 6, 2010 at 12:49, Dan McGee <dpmcgee at gmail.com> wrote:
>> I can't get this to apply. Can you try resending and making sure
>> spaces don't get eaten and it isn't base64 encoded?
>>
>> -Dan
>
> I suspect it was because of the gmail hoops I had to jump through...
> git send-email failed because it can only send from my daenyth@
> address rather than daenyth+arch@ (my subscribed name), so I had to
> send it to myself and forward it...
>
> Adding as an attachment which should hopefully keep it intact. I've
> rebased it against master as well.

Fail.

$ ./scripts/rankmirrors /etc/pacman.d/mirrorlist
# Server list generated by rankmirrors on 2010-05-07
# Server list generated by rankmirrors on 2009-01-04
#
# Arch Linux repository mirrorlist
#
#Server = http://localhost:8954/search/$repo/os/x86_64
url `' is malformed.

Why doesn't this default to anything? I think your logic in there
might be backwards.

Can you add a Signed-off-by: line as well when you fix it? Thanks!

-Dan