[pacman-dev] [PATCH] [bash_completion] Undeclared local vars/filenames with spaces/other

Xavier Chantry shiningxc at gmail.com
Sat May 8 09:54:16 CEST 2010

On Wed, Jan 20, 2010 at 9:27 AM, Andres Perera <andres87p at gmail.com> wrote:
> Uh, I broke the spaces with git's 72 textwidth.
> Same patch attached...

I don't understand what you mean, this is the diff between original
and new patch :

diff --git a/contrib/bash_completion b/contrib/bash_completion
index 2f6cd06..b1162ad 100644
--- a/contrib/bash_completion
+++ b/contrib/bash_completion
@@ -1,6 +1,6 @@
 # pacman/makepkg completion by Andres Perera <andres87p gmail>
-# Distributed under the terms of the GNU General Public License v3 or
+# Distributed under the terms of the GNU General Public License v2 or
 # later.
 #   Local variables: common core cur glob list long m o prev query r
@@ -56,7 +56,7 @@ _makepkg_count_words() {
 _makepkg() {

-  local prev cur short long parse glob
+  local prev cur short long

I see you reverted the license and made another change, but no space change.
I am not sure what you mean with git's 72 textwidth , isnt that just
commit log ? Your original commit log was fine.
Also it's much easier for us if you keep submitting git patches with the log.
And finally the patch now only applies against maint, not master, but
maybe that's our fault of not applying it earlier :)

More information about the pacman-dev mailing list