[pacman-dev] [PATCH] database/print options, fix dirs, other

[Xavier Chantry]

On Mon, May 10, 2010 at 1:27 AM, Andres P <stderr at mail.com> wrote:
> On Sun, May 9, 2010 at 4:33 PM, Xavier Chantry
> <chantry.xavier at gmail.com> wrote:
>> What did you use to send this patch ?
>> Can you please use git send-email if you didn't ?
>> And if you cannot do that, an attachment would be better.
>
> Good because I messed some stuff up
>

Thanks, that last patch looks good and has everything I asked :)

Just two comments :
1) Dan is still not happy about license change, even if this is a full
rewrite. He would like to have all files in pacman project licensed
with GPL2.
But if you put this in public domain, I believe Dan could just
relicense it in GPL2 himself.
Anyway I don't like acting as an intermediary here, hopefully Dan and
you can resolve this together.

2) Related to the directory completion I mentioned earlier : you
restored old behavior, which is good.
But the old behavior has a bug. It's not a regression in your patch,
so not a show stopper, just wondering if you might have an idea.
When there is both a directory and a package with the same name, the
completion only sees the directory, and thus adds a trailing slash.

$ mkdir acpitool
$ pacman -S acpi<tab>
acpi      acpid     acpitool/
$ pacman -S acpit<tab>
$ pacman -S acpitool/
error: repository 'acpitool' not found
error: 'acpitool/': no such repository