[pacman-dev] [PATCH] [makepkg] useless use of grep
Allan McRae
allan at archlinux.org
Sat May 22 08:49:50 EDT 2010
On 22/05/10 15:06, Andres P wrote:
> Looked like slackware's makepkg
>
> Signed-off-by: Andres P<aepd87 at gmail.com>
Pushed to my working branch. Although removed the commit message as it
had absolutely no relevance.
> ---
>
> Maybe it should be a function:
> sed_bscript() { sed -n "s/^\([[:space:]]*\)$1=/\1/p" "$BUILDSCRIPT"; }
> Then there's only one regex to maintain:
> local install_files=($(sed_bscript install))
> local changelog_files=($(sed_bscript changelog))
I thought about this when committing the original grep regex but came to
the conclusion that it is only four locations and are quite unlikely to
change often, so I think it will be fine to leave it as is.
Allan
More information about the pacman-dev
mailing list