[pacman-dev] [PATCH] [makepkg] use double brackets
allan at archlinux.org
Sat May 22 19:04:46 EDT 2010
On 23/05/10 01:23, Xavier Chantry wrote:
> On Sat, May 22, 2010 at 5:14 PM, Dan McGee<dpmcgee at gmail.com> wrote:
>> On Sat, May 22, 2010 at 1:48 AM, Allan McRae<allan at archlinux.org> wrote:
>>> In fact, thinking about this more. Bash-4.1 was released on 2010-01-03 so
>>> it will have been out for ~6 months before the next pacman release. Anyone
>>> upgrading their package manager from 3.3 -> 3.4 will upgrade bash from 4.0
>>> -> 4.1 so this is probably a non-issue.
>>> So I will accept this patch when the comment above and "stray" ! is removed
>>> with it.
>> You are assuming Arch users only here; has Cygwin and OS X moved from
>> bash 3.X to 4.X yet? I'd rather not break this just for the sake of
>> getting this patch in.
> Damn I knew there was some mails I meant to reply and forgot about.
> If it's that easy to remain compatibility with bash 3, better keep it that way.
> IMO it's fine to drop support for bash 3 as soon as it becomes a
> burden and we have a good reason for requiring bash 4. But that does
> not seem to be the case for now.
This does not break compatibility with bash-3.x. Just bash-4.0 which
had a bug in it in the way it handles the type tests.
In bash-4.0 _only_:
if [[ $(type -t build) == "function" ]]
sets of the error trap if the build function does not exist. In all
other version of bash, that works fine.
I am fine with dropping compatibility with bash-4.0 because any
distribution (am I am including MacOSX and cygwin under that banner)
that upgrades to bash-4 now will not be using bash-4.0.
More information about the pacman-dev