[pacman-dev] [PATCH] makepkg: bad code rep in bscript parsing

Xavier Chantry chantry.xavier at gmail.com
Sun May 23 12:43:21 EDT 2010

On Sun, May 23, 2010 at 2:20 PM, Allan McRae <allan at archlinux.org> wrote:
> On 23/05/10 20:58, Andres P wrote:
>> Signed-off-by: Andres P<aepd87 at gmail.com>
>> ---
> -1 from me.  The new function does two things that are completely unrelated
> apart from the regex they use.  It makes no sense to combine them.  Also the
> function name does not reflect what it does at all.
> There is a limit to how much code refactoring is useful.  It needs to be
> balanced by readability.

There is a double combination in that patch.
IMO one of them is fine, the one that combines install and changelog
in a for loop.
And that combination could be done in the two places, but keeping them separate.

More information about the pacman-dev mailing list