[pacman-dev] [PATCH 2/2] use execv to avoid using sh just to run ldconfig

Xavier Chantry chantry.xavier at gmail.com
Mon May 24 06:32:39 EDT 2010

On Mon, May 24, 2010 at 8:49 AM, Jonathan Conder <j at skurvy.no-ip.org> wrote:
> Signed-off-by: Jonathan Conder <j at skurvy.no-ip.org>
> ---
>  lib/libalpm/trans.c |    3 ++-
>  lib/libalpm/util.c  |    9 +++++----
>  lib/libalpm/util.h  |    2 +-
>  3 files changed, 8 insertions(+), 6 deletions(-)
> The _alpm_log line below (around 467,7) won't be as detailed as it was before,
> can anyone suggest a solution for this?

IMO that log line was not very informative in the first place as it
showed the temporary scriptlet file which only exists at runtime and
is deleted right after being used.
BTW we are not constrained to log from run_chroot at all, we could
actually have a more informative debug line by logging (inside)
alpm_runscriptlet and its arguments.

Otherwise the two patches look good to me, thanks !

More information about the pacman-dev mailing list