[pacman-dev] [PATCH] makepkg: don't decompress when stripping binaries

[Dan McGee]

On Mon, May 24, 2010 at 4:32 PM, Andres P <aepd87 at gmail.com> wrote:
> f569c4a042 wrongly relied on file's output.
>
> The fix is to not decompress files in the first place.
>
> Signed-off-by: Andres P <aepd87 at gmail.com>

Seems good to me, I'll pull this locally unless Allan has objections.

> ---
>  scripts/makepkg.sh.in |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 1707245..49dc714 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -869,9 +869,7 @@ tidy_install() {
>                msg2 "$(gettext "Stripping unneeded symbols from binaries and libraries...")"
>                local binary
>                find ${STRIP_DIRS[@]} -type f -perm -u+w 2>/dev/null | while read binary ; do
> -                       case "$(file -biz "$binary")" in
> -                               *compressed-encoding*)      # Skip compressed binaries
> -                                       ;;
> +                       case "$(file -bi "$binary")" in
>                                *application/x-sharedlib*)  # Libraries (.so)
>                                        /usr/bin/strip $STRIP_SHARED "$binary";;
>                                *application/x-archive*)    # Libraries (.a)
> --
> 1.7.1
>
>
>