[pacman-dev] [PATCH] makepkg: Add a late check if package exists when using package functions

[Allan McRae]

On 26/05/10 02:00, Nezmer wrote:
> pkgver and pkgrel can be overridden in package functions. makepkg can't
> use the overridden values when doing the early check if a package file
> already exists. That means makepkg will silently delete the existing
> package file and generate a new one.
>
> pkgbase=N
> pkgname=(N1 N2)
> pkgver=1
> pkgrel=1
> arch=(any)
>
> package_N1() {
>    pkgver=v1
> }
>
> package_N2() {
>    pkgver=v2
> }
>
> Signed-off-by: Nezmer<git at nezmer.info>


I am not sure about this...   I am of the opinion that if you have to 
override pkgver in every package function, then your default value is 
wrong.  With a better default pkgver, the check should detect at least 
one of your packages is already built and abort.

Also, I really do not like the erroring out after all the packages have 
been built  (although "makepkg -R" would save all that work).  I think 
these conditions should be an error out early or not at all.

Allan