[pacman-dev] [PATCH] makepkg: use type -p's return value for PATH checks
Allan McRae
allan at archlinux.org
Thu May 27 11:29:09 EDT 2010
On 28/05/10 01:06, Andres P wrote:
> Rely on type -p's return value instead of a string check.
>
> And gettext was previously being checked with type -t, which was
> inconsistent with the rest of the tests pertaining commands that aren't
> expected to be functions nor builtins.
>
> Signed-off-by: Andres P<aepd87 at gmail.com>
> ---
> this is a resubmit
>
> v2.1: correct -1749,7 +1749,7-ish syntax err (thanks cedric)
>
> v2: inline function
>
> scripts/makepkg.sh.in | 26 +++++++++++++-------------
> 1 files changed, 13 insertions(+), 13 deletions(-)
>
This version is fine to be applied. However, we are now close to
releasing 3.4 so not much apart from bug fixes will make it to master
until that is done. Pushed to my post-3.4 branch so it does not get
lost in the meantime.
Allan
More information about the pacman-dev
mailing list