[pacman-dev] [PATCH] [Idea] makepkg: Extract from any file bsdtar can recognize

Andres P aepd87 at gmail.com
Sat May 29 17:08:17 EDT 2010

On Sat, May 29, 2010 at 03:44:07PM -0400, Nezmer wrote:
> If "file -bizL" does not return a supported type. Check if the dist file
> is recognized by bsdtar and if yes extract from it.
This is great, but I think this check:
>   if bsdtar -tf "$file" &>/dev/null; then
Should come before:
>   local file_type=$(file -bizL "$file")

If bsdtar -tf is deemed as reliable, then it should make the file(1)
check redundant, seeing that makepkg uses bsdtar to extract.

Andres P

More information about the pacman-dev mailing list