[pacman-dev] Disk space checking branch "complete"

[Allan McRae]

On 17/11/10 03:25, Nezmer wrote:
> On Tue, Nov 16, 2010 at 09:03:37PM +1000, Allan McRae wrote:
>> On 16/11/10 18:02, Bryce Gibson wrote:
>>> Hi Allan,
>>> I just wanted to ask, it looks like your patches will make a sync fail if it
>>> finds there's not enough space, is that correct?
>>> Because I'd suggest a warning may be more appropriate, especially for use
>>> cases like compressed filesystems.
>>> Cheers
>>> Bryce
>>> ps. I noticed that space checking can be completely disabled via
>>> pacman.conf, which may be seen as a suitable solution for people in these
>>> types of situation.
>>
>> Disabling checking in pacman.conf is what I would recommend in these
>> sort of cases.  These are the sort of things we will only find out
>> after we get some widespread usage of the feature.  I would be
>> interested in what the size calculations actually do on compressed
>> filesystems.
>>
>> Allan
>>
>>
>
> On the topic of FS compression(also FS caching and delayed allocation).
>
> The real issue I had was the calculation of install size when building
> the package. The calculated size was always *very* small. I addressed
> this issue with 2 patches. The 1st one (adding sync before running du)
> didn't fix anything. The 2nd patch worked pretty well.
>
> http://gitorious.org/pacman-bsd/pacman-bsd/commit/8b367d4441ba85b5548285d987afcfc84c4fcb3e
> http://gitorious.org/pacman-bsd/pacman-bsd/commit/cf3341fe591293a493bc925e0433a1f696b37d90

I think that initial "sync" is not needed because du does one anyway. 
The second one looks interesting so I have bookmarked it to look at later.

Allan