[pacman-dev] [PATCH] Warn when synchronizing without upgrading (-Sy)

[Thomas Bahn]

Am Mittwoch 17 November 2010, 21:46:23 schrieb Evangelos Foutras:
> Doing so can lead to broken applications after soname bumps, or major
> version upgrades like the transition to Python 3.
> ---
>  src/pacman/sync.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/src/pacman/sync.c b/src/pacman/sync.c
> index f9d12e4..e7b7628 100644
> --- a/src/pacman/sync.c
> +++ b/src/pacman/sync.c
> @@ -805,6 +805,14 @@ int pacman_sync(alpm_list_t *targets)
>  	}
> 
>  	if(config->op_s_sync) {
> +		/* Warn the user when synchronizing the package databases without also
> +		 * performing a full upgrade. */
> +		if (!config->op_s_upgrade && !noyes(_(":: Synchronizing the package "
> +				"databases without also performing a full upgrade \n"
> +				":: can lead to software incompatibilities. "
> +				"Continue anyway?"))) {
> +			return(0);
> +		}
>  		/* grab a fresh package list */
>  		printf(_(":: Synchronizing package databases...\n"));
>  		alpm_logaction("synchronizing package lists\n");


Hello,

this patch introduces a question on every repository sync if a am right. So 
that patch also asks if you type 'pacman -Syu' ? If it is i would not vote for 
this patch, because it's another question you must acknoweledge every system 
update.

If it only asks on 'pacman -Sy <package>' then its ok for me. Another 
suggestion, only print this warning and don't ask. An arch user would read the 
output of pacman and its package pre/post-scripts and is warned.

What do you think?