[pacman-dev] We've broken the bash

[Dan McGee]

On Wed, Oct 13, 2010 at 10:12 AM, Allan McRae <allan at archlinux.org> wrote:
> On 14/10/10 01:11, Allan McRae wrote:
>>
>> On 14/10/10 00:59, Dan McGee wrote:
>>>
>>> On Wed, Oct 13, 2010 at 9:54 AM, Allan McRae<allan at archlinux.org> wrote:
>>>>
>>>> On 14/10/10 00:11, Dan McGee wrote:
>>>>>
>>>>> I think this was alluded to a while back, but we are starting to show
>>>>> some problems with our naming scheme and bash variable/function naming
>>>>> rules:
>>>>>
>>>>> /usr/bin/makepkg: line 1831: declare: `package_python-xlwt': not a
>>>>> valid identifier
>>>>>
>>>>> With latest makepkg built from git.
>>>>>
>>>>
>>>> Any chance of some more info on how to replicate? At least the
>>>> pkgname line
>>>> or even the whole PKGBUILD?
>>>
>>> Haha, my bad.
>>>
>>> wget http://aur.archlinux.org/packages/python-xlwt/python-xlwt.tar.gz
>>> bsdtar xf python-xlwt.tar.gz
>>> cd python-xlwt
>>> makepkg
>>>
>>
>> I can not replicate with 4.1.x or 3.2.x.
>
>                           ^ these are bash version....

Hmmmmm. Build output attached, and here is the relevant part of this
particular version of makepkg:

1825 # test for available PKGBUILD functions
1826 if declare -f build >/dev/null; then
1827   BUILDFUNC=1
1828 fi
1829 if declare -f package >/dev/null; then
1830   PKGFUNC=1
1831 elif [[ $SPLITPKG -eq 0 ]] && declare -f package_${pkgname}
>/dev/null; then
1832   SPLITPKG=1
1833 fi

-Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: makepkg-declare-fail.txt.gz
Type: application/x-gzip
Size: 2032 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20101013/8866f0ec/attachment-0001.bin>