[pacman-dev] Contributing BSD patches upstream

[Dan McGee]

On Thu, Oct 7, 2010 at 3:46 PM, Dan McGee <dpmcgee at gmail.com> wrote:
> On Wed, Oct 6, 2010 at 6:38 AM, Nezmer <me at nezmer.info> wrote:
>> On Tue, Oct 05, 2010 at 07:56:53PM -0500, Dan McGee wrote:
>>> My quick review of the differences picked out these things as stuff
>>> that should/could be looked at to improve compatibility and
>>> correctness:
>>>
>>> 1. DBPath/CacheDir parsing in scripts/ and contrib/
>>> 2. Fix bash regexes: =~ should never have RHS quotes
>>> 3. Hardcoded '.tar.gz' in some contrib/ scripts
>>> 4. contrib/, use configurable etc/ directory (sysconfdir I believe)
>>> 5. bsdtar binary location, don't assume it is on path?
>>> 6. Use of seq (not a bash builtin)
>>> 7. makepkg: strip binary location hardcoded, perhaps use $STRIP
>>> 8. makepkg: mknod vs. mkfifo
>>> 9. bash shebang in scripts
>>>
>>> -Dan
>>
>> Just saw this. A very good summary.
>>
>> I'm welling to answer any questions or put together any patch you are
>> interested to take.
>
> I'd basically say anything that is in the above list is fair game for
> patches. #2 and #3 are pretty low-hanging, non-invasive stuff if you'd
> like somewhere to start.
>
> I think I just handled #6 as we only used it in one contrib script;
> patch going to the ML. This message is also going to the ML so we can
> maybe get some discussion going there.
>
> -Dan
>

OK, so we're down to this:

>>> 1. DBPath/CacheDir parsing in scripts/ and contrib/
>>> 2. Fix bash regexes: =~ should never have RHS quotes
To find them:
$ git grep "=~.*[\"']"

>>> 3. Hardcoded '.tar.gz' in some contrib/ scripts
Just this line in wget-xdelta?
if ! [[ "$out_file" =~ "pkg.tar.gz" ]]; then

>>> 5. bsdtar binary location, don't assume it is on path?
Maybe we do another AC_PATH_PROG() check? Not sure.

>>> 7. makepkg: strip binary location hardcoded, perhaps use $STRIP
Ditto to the above thought.

-Dan