[pacman-dev] [PATCH] Read 'force' entry from packages
chantry.xavier at gmail.com
Fri Oct 15 05:23:49 EDT 2010
On Fri, Oct 15, 2010 at 3:15 AM, Dan McGee <dpmcgee at gmail.com> wrote:
> So yes, I'm a bit torn here, but I always fall on the "let's not touch
> maint more than necessary" side of the fence, and this starts to push
> that line. I'm fine with the "read force from package" patch, but the
> rest I'm just not so keen on.
As I said, if we want to be strict on the "let's not touch maint more
than necessary", we can drop your patch too. It's not necessary, is it
? It will save 10 seconds on one and only one -Su operation.
If not, my additional patch is not a half-feature, it's an one-line
change in a completely dead and unused codepath (before your patch).
Its consequences are also simpler to appreciate : we just write EPOCH
instead of FORCE, and db_read simply ignores unknown lines. Your first
patch is less obvious : we now set pkg->force when loading a package
from its file, does it really have no impact anywhere in the codebase
besides db_write ? (Looks fine.)
The only purpose of these two proposals (dropping your patch or adding
mine) is to provide an answer to the question 'When can we drop
reading FORCE from local db over which we have no real control?' and
the answer is 'right now'.
Ok this is a very minor benefit, but you should give me at least an
equally minor drawback for each of the proposal before rejecting them.
More information about the pacman-dev