[pacman-dev] [PATCH 2/3] Use OpenSSL MD5 crypto functions if available

Allan McRae allan at archlinux.org
Sun Sep 5 08:30:10 EDT 2010


On 05/09/10 22:10, Allan McRae wrote:
> On 04/09/10 19:16, Jürgen Hötzel wrote:
>> Hi Dan,
>>
>> 2010/9/2 Dan McGee<dan at archlinux.org>:
>>> This does not remove the MD5 code from our codebase, but it does enable
>>> linking against OpenSSL to get their much faster implementation if it is
>>> available on whatever platform you are using. At configure-time, we will
>>> default to using it if it is available, but this can be easily
>>> changed by
>>> using the `--with-openssl` or `--without-openssl` arguments to
>>> configure.
>>
>> What about just replacing the current MD5 implementation with the
>> OpenSSL implementation?
>>
>> This would prevent conditional compilation and a direct OpenSSL
>> dependency in libalpm.
>
> Can we do that? Openssl is BSD code.
>
>
> Anyway, I have concerns... Think of an openssl upgrade. pacman is in
> SyncFirst and it pulls in all its deps. If that pulls in openssl with a
> soname bump, things may get interesting. I have not check, but I do not
> think --as-needed saves us there.

Just did a build from git and that is definitely the case.  libalpm 
links to libssl so this will make for very interesting openssl soname 
bumps in the future.

Allan



More information about the pacman-dev mailing list