[pacman-dev] [PATCH 1/5] pacman-key: keyring management tool

[Guillaume ALAUX]

On 20 September 2010 13:58, Allan McRae <allan at archlinux.org> wrote:
> Hi,
>
> FYI, it is much easier to comment (and separate comments from the patch) if
> things are posted inline.   Here goes some brief comments in cut paste sort
> of format...  hopefully you can follow them.
>
> Anyway, overall this looks quite good.  Make these small adjustments it is
> basically good to go.  Even better if you submit as a patch with the
> necessary autotools changes, but I can handle those if not.
>
>
>> Description
>> -----------
>> The script *pacman-key* manage *pacman*'s keyring, ie the keyring of GnuPG
>> keys used to sign packages.
>> It enables to import, export and fetch keys from keyservers as well as
>> update the key trust database.
>
> Hmm...  how about something like:
>
> The script *pacman-key* manage *pacman*'s keyring, which is the collection
> of GnuPG keys used to check signed packages.
> It provides the ability to import and export keys, fetch keys from
> keyservers and update the key trust database.
>
>
>> *\--config* 'file'::
>>       Set an alternative configuration file to use (default is
>> /etc/pacman.conf)
>
> you should use {sysconfdir}/pacman.conf instead so we can adjust this based
> on the configure output.
>
>
>> *-l*, *\--list*::
>>       List keys and signatures in pacman's keyring. Same as option
>> \--list-sigs of GnuPG. See GnuPG's man pages for flag significations
>
> Equivalent to --list-sigs from GnuPG.  (?)
>
>
>> *-u*, *\--updatedb*::
>>       Update the trustdb of pacman. Same as option \--check-trustdb of
>> GnuPG.
>
> Equivalent to \--check-trustdb in GnuPG
>
>
> Allan

Hello,

> it is much easier to comment if things are posted inline
OK I hadn't think about it !

> Make these small adjustments it is basically good to go
They also look OK to me, I will change that.

> Even better if you submit as a patch with the necessary autotools changes
Will try to :)

--
Guillaume