[pacman-dev] [PATCH] makepkg: canonicalize paths from environmental variables

Allan McRae allan at archlinux.org
Wed Sep 29 09:52:33 EDT 2010


On 29/09/10 23:25, Dan McGee wrote:
> On Wed, Sep 29, 2010 at 8:15 AM, Allan McRae<allan at archlinux.org>  wrote:
>> On 29/09/10 22:41, Allan McRae wrote:
>>>
>>> On 29/09/10 22:33, Allan McRae wrote:
>>>>
>>>> This prevents circular symlinks and weird final package locations
>>>> when using commands like 'PKGDEST="." makepkg'.
>>>>
>>>> Fixes FS#20922.
>>>>
>>>> Signed-off-by: Allan McRae<allan at archlinux.org>
>>>> ---
>>>>
>>>> Note that this adds readlink as a dependency to makepkg. That is provided
>>>> by coreutils which is essential anyway so I do not think this is an
>>>> issue.
>>>>
>>>
>>> And I may be wrong... it appears readlink does different things with -f
>>> on OSX/BSD. Off to find a more compatible solution.
>>>
>>
>> Could any BSD/OSX users report on whether "realpath ." give the full path?
>
> It worked fine according to this: c8a41b7d6da7f820754a07cb085687ea5e110f85
>

Just to clarify (thanks to Xavier), it worked on BSD but not in OSX 
which does not have either "readlink -f" or "realpath"...

Argh!



More information about the pacman-dev mailing list