[pacman-dev] [PATCH] makepkg: improve srcdir check and add pkgdir

[Loui Chang]

On Thu 30 Sep 2010 12:10 +1000, Allan McRae wrote:
> On 30/09/10 11:56, Loui Chang wrote:
> >On Wed 29 Sep 2010 21:59 +1000, Allan McRae wrote:
> >>The checking of the package for $srcdir references was overly
> >>sensitive and gave a lot of what appear to be false positives with
> >>binary files (in particular with debugging symbols kept).
> >>
> >>Restrict the search for $srcdir to non-binary files as this should
> >>still catch the majority of configuration issues the check was
> >>initially designed to catch. Also, add a similar check for $pkgdir.
> >
> >Just curious. Shouldn't these checks really be part of namcap rather
> >than makepkg?
> 
> How would namcap know where a package was built?

I haven't thought of the implementation. How would you implement it?

I wondered since namcap is the package checking tool that it should have
such functionality rather than makepkg itself.

Perhaps makepkg could hand things off to namcap if the packager wishes
to check the package for any issues.