[pacman-dev] [PATCH] Fix -Wshadow warnings

[Xavier]

Allan McRae wrote:
> 
> But do we really want to add all these warnings in there?   I use
> all of these:
> 
> -Wclobbered -Wempty-body -Wfloat-equal -Wignored-qualifiers
> -Wmissing-declarations -Wmissing-parameter-type -Wmissing-prototypes
> -Wold-style-declaration -Woverride-init -Wsign-compare
> -Wstrict-prototypes -Wtype-limits -Wuninitialized
> 
> I'm not sure anybody wants that...
> 

If they pass (or close to), why not ? Developers should follow the same rules to
not break something that was respected before and to keep a consistent codebase.