[pacman-dev] [PATCH 3/4] lib/dload: major refactor of signature downloading

[Dave Reisner]

On Wed, Apr 20, 2011 at 07:03:49PM -0500, Dan McGee wrote:
> On Mon, Mar 28, 2011 at 2:15 PM, Dave Reisner <d at falconindy.com> wrote:
> > There's a lot of related moving parts here:
> > * iteration through mirrors is moved back to the calling functions. this
> >  allows removal of _alpm_download_single_file and _alpm_download_files
> > * rename download => _alpm_download. also modified to accept an extra
> >  arg of type pgp_verify_t which is passed through to
> >  curl_download_internal
> > * move the actual signature download to curl_download_internal. this
> >  allows us to ensure that the signature and the file came from the
> >  same mirror, and only to accept the file if signature verification
> >  passes.
> >
> > Signed-off-by: Dave Reisner <d at falconindy.com>
> 
> This one needs a little more testing...note the (now) non-existant
> core.db file, and the completely bogus community2.
> 
> dmcgee at galway ~/projects/pacman (master)
> $ sudo rm /var/lib/pacman/sync/core.db
> 
> dmcgee at galway ~/projects/pacman (master)
> $ sudo ./src/pacman/pacman -Sy
> :: Synchronizing package databases...
>  testing is up to date
>  core is up to date
>  extra is up to date
>  community-testing is up to date
>  multilib is up to date
>  community is up to date
>  community2 is up to date
> 
> -Dan
> 

Good choice. I've noticed some other garbage in these patches as well.
Hoping to tackle a lot of this next week when I'm off from work.

d