[pacman-dev] [PATCH 3/4] sync.c: remove unnecessary check for PM_PGP_VERIFY_UNKNOWN

Dan McGee dpmcgee at gmail.com
Thu Apr 21 13:16:21 EDT 2011

On Thu, Apr 21, 2011 at 1:38 AM, Rémy Oudompheng
<remyoudompheng at gmail.com> wrote:
> The value PM_PGP_VERIFY_UNKNOWN is reserved to error cases,
> now that the signature verification level defaults to the
> globally set level. The only error case is when handle == NULL,
> which is false in the context of _alpm_sync_commit().
> Signed-off-by: Rémy Oudompheng <remy at archlinux.org>
> ---
> Now I'm unsure about this patch. We could miss the case where sdb is NULL
> but then, the log message would do a NULL dereference.

You would have been dead meat long before this if sdb was NULL, so
nothing to worry about. Patch pushed.

More information about the pacman-dev mailing list