[pacman-dev] [PATCH 4/4] libalpm/dload: major refactor of signature downloading

Allan McRae allan at archlinux.org
Sun Apr 24 08:09:14 EDT 2011


On 22/04/11 09:36, Dan McGee wrote:
> There's a lot of related moving parts here:
> * Iteration through mirrors is moved back to the calling functions. This
>    allows removal of _alpm_download_single_file and _alpm_download_files.
> * The download function gets a few more arguments to influence behavior.
>    This allows several different scenarios to customize behavior:
>    - database
>    - database signature (req'd and optional)
>    - package
>    - package via direct URL
>    - package signature via direct URL (req'd and optional)
> * For databases, we need signatures from the same mirror, so structure
>    the code accordingly.
>
> Some-inspiration-from: Dave Reisner<d at falconindy.com>
> Signed-off-by: Dan McGee<dan at archlinux.org>

Signed-off-by: Allan

Extends to PATCH 3/4 in this series too.  Both patches look good to me 
and I have been unable to break them in the last couple of days.

Allan



More information about the pacman-dev mailing list