[pacman-dev] [PATCH 3/5] Clean is done everytime it's asked for

Dave Reisner d at falconindy.com
Fri Aug 12 12:58:01 EDT 2011


On Tue, Aug 09, 2011 at 12:56:41PM +0200, Sebastien Luttringer wrote:
> Before this, cleaning is done when script exit with a value != 0.
> If a build fail, directory remain unclean. The purpose of cleaning should
> not be changed if build fail.

I think this is intended behavior. One might want to investigate _why_ a
build failed by looking in the $srcdir.

dave

> Signed-off-by: Sebastien Luttringer <seblu at seblu.net>
> ---
>  scripts/makepkg.sh.in |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index fa12702..05880b7 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -134,10 +134,10 @@ clean_up() {
>  		return
>  	fi
>  
> -	if (( ! EXIT_CODE && CLEANUP )); then
> +	if (( CLEANUP )); then
>  		local pkg file
>  
> -		# If it's a clean exit and -c/--clean has been passed...
> +		# Cleaning if -c/--clean has been passed...
>  		msg "$(gettext "Cleaning up...")"
>  		rm -rf "$pkgdir" "$srcdir"
>  		if [[ -n $pkgbase ]]; then
> -- 
> Sebastien "Seblu" Luttringer
> 
> 


More information about the pacman-dev mailing list